[PATCH] D48404: Don't modify LibFuncs in DeadArgumentElimination or ArgumentPromotion

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 21 13:12:39 PDT 2018


lebedev.ri added inline comments.


================
Comment at: lib/Transforms/IPO/ArgumentPromotion.cpp:831-832
 
+  // Don't promote arguments for library functions. We can make assumptions
+  // about library function signatures in later passes.
+  LibFunc LF;
----------------
This reads weird.
Are you sure you didn't mean:
```
// Don't promote arguments for library functions,
// because later passes may make assumptions about library function signatures.
```


Repository:
  rL LLVM

https://reviews.llvm.org/D48404





More information about the llvm-commits mailing list