[PATCH] D48446: [ubsan] Add support for reporting diagnostics to a monitor process

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: lib/ubsan/ubsan_monitor.cc:53
+  InternalScopedString &Buf = CurrentUBR->Buffer;
+  char FirstChar = Buf.data()[0];
+  if (FirstChar >= 'a' && FirstChar <= 'z')
----------------
vsk wrote:
> vitalybuka wrote:
> > why do you need this?
> This is a relatively noninvasive way of making sure the text of diagnostics can't begin with a lowercase letter. I'll add a comment.
Thanks. That's clear from the code.
I am rather curios why it's important. Is this always upper case for messages from other components passed to monitor?


https://reviews.llvm.org/D48446