[PATCH] D48450: [DataFormatter] Add CFDictionary data formatter

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 21 11:41:32 PDT 2018


clayborg added a comment.

It might be nice to split up the tests a bit. The data formatter tests have a history of testing 1000 things at once and saying "something failed in the this test with 1000 things". It would be nice if we knew that only dictionaries were failing by testing each type individually. Not required for this test, but try this out by reverting the changes in NSDictionary.cpp so you can see the kind of issue I am talking about.


Repository:
  rL LLVM

https://reviews.llvm.org/D48450





More information about the llvm-commits mailing list