[PATCH] D45637: [DebugInfo] Ignore DBG_VALUE instructions in PostRA Machine Sink

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 21 08:41:14 PDT 2018


bjope accepted this revision.
bjope added a comment.
This revision is now accepted and ready to land.

We all have some suspicions that it might be awkward to move a DBG_VALUE intrinsic across another one for the *same* *variable*. But we haven't seen that happen in this particular situation when having an end-to-end test with C/C++ input. I'm pretty sure such things can happen in other passes (e.g. CodegenPrepare is moving dbg.value without any checks at all), so it is more like a general concern.

And it seems like we agree that alternative 3 ("Land this patch, if there is nothing obviously wrong :), and then file a bug for the improvement noted above.") is the way forward.

LGTM!


https://reviews.llvm.org/D45637





More information about the llvm-commits mailing list