[PATCH] D48404: Don't modify LibFuncs in LTO

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 20 17:18:42 PDT 2018


dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.

A nit about the commit message: it's not just LTO passes that make assumptions about known library functions, lots of passes do. Also I might be just a little bit more explicit than "when statically linking libc" and make it "when including libc in LTO"
Otherwise LGTM



================
Comment at: lib/Transforms/IPO/DeadArgumentElimination.cpp:83
       ModuleAnalysisManager DummyMAM;
+      DummyMAM.registerPass([&] { return TargetLibraryAnalysis(); });
       PreservedAnalyses PA = DAEP.run(M, DummyMAM);
----------------
I guess this isn't really a DummyMAM anymore if we are registering analyses on it?


Repository:
  rL LLVM

https://reviews.llvm.org/D48404





More information about the llvm-commits mailing list