[PATCH] D48283: [SCEV] Properly solve quadratic equations with coefficients in i1

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 20 17:05:45 PDT 2018


efriedma added subscribers: jonpa, efriedma.
efriedma added a comment.

See also https://bugs.llvm.org//show_bug.cgi?id=37211 .

I'm tempted to just delete the code instead, given it's screwed up in multiple ways: we shouldn't be dividing by two at all, even if the bitwidth isn't one. (It looks like someone took the quadratic formula for real numbers, and blindly translated it without considering that SCEV expressions aren't real numbers.)


Repository:
  rL LLVM

https://reviews.llvm.org/D48283





More information about the llvm-commits mailing list