[PATCH] D48394: [WebAssembly] Error on mismatched function signature in final output

[Jacob Gravelle via Phabricator via llvm-commits]

jgravelle-google accepted this revision.
jgravelle-google added inline comments.
This revision is now accepted and ready to land.


================
Comment at: wasm/SymbolTable.cpp:134
+      Existing->SignatureMismatch = true;
+      warn(msg);
+    } else {
----------------
It feels odd to me that we warn about a mismatch, and then later on error with the same message. Would feel more natural to only print the error, though it's probably useful enough to have the ">>> defind as" context that it's fine as-is.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D48394