[PATCH] D48202: Generalize MergeBlockIntoPredecessor. Replace uses of MergeBasicBlockIntoOnlyPred.

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 20 13:42:02 PDT 2018


asbirlea marked 4 inline comments as done.
asbirlea added a comment.

Thank you for the review!



================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:779-780
+      MergeBlockIntoPredecessor(DestBB);
+      // Note: BB will not be deleted on this path, its single predecessor will.
+      LLVM_DEBUG(dbgs() << "AFTER:\n" << *SinglePred << "\n\n\n");
       return;
----------------
chandlerc wrote:
> This seems like a bug then -- we can't print the `SinglePred` after it is deleted...
Updated comment, SinglePred is not deleted.


Repository:
  rL LLVM

https://reviews.llvm.org/D48202





More information about the llvm-commits mailing list