[PATCH] D45637: [DebugInfo] Ignore DBG_VALUE instructions in PostRA Machine Sink

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added subscribers: probinson, aprantl.
bjope added a comment.

In https://reviews.llvm.org/D45637#1137912, @mattd wrote:

> Just pinging this.  @bjope has provided great feedback (thanks!), but I am wondering if anyone else thinks this patch is useful, or if I should abandon it in favor of some other solution?


FWIW: I just want to clarify that I think this patch is better than doing nothing at all. And I'm not sure exactly what should be expected when it comes to reordering DBG_VALUE instructions referencing the same variable. After all, if we do heavy optimizations the user must be aware that debug-experience can be confusing sometimes, so maybe I was overthinking the situation.

@aprantl or @probinson usually have a good feeling about what is reasonable to do. Have you seen this discussion?


https://reviews.llvm.org/D45637