[PATCH] D48172: [CostModel][AArch64] Add some initial costs for SK_Select and SK_PermuteSingleSrc

Evandro Menezes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 20 08:32:36 PDT 2018


evandro added a comment.

Next time, when one patch causes a regression that another patch fixes, please, make the one a parent of the other.



================
Comment at: lib/Target/AArch64/AArch64TargetTransformInfo.cpp:967
+      return LT.first;
+    if (EltBits == 32)
+        return LT.first * LT.second.getSizeInBits() / 64;
----------------
Perhaps you should assert instead of testing here.


================
Comment at: lib/Target/AArch64/AArch64TargetTransformInfo.cpp:976
+      return LT.first;
+    if (EltBits == 32)
+      return LT.first * LT.second.getSizeInBits() / 64;
----------------
Ditto.


Repository:
  rL LLVM

https://reviews.llvm.org/D48172





More information about the llvm-commits mailing list