[PATCH] D48344: [DWARF] Improved error reporting for range lists

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 20 03:19:31 PDT 2018


JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

Thanks Wolfgang, I'm always excited to see improved error handling! LGTM modulo inline comment.



================
Comment at: lib/DebugInfo/DWARF/DWARFUnit.cpp:417
+
+  return make_error<StringError>("Missing or invalid range list table",
+                                 inconvertibleErrorCode());
----------------
Did you capitalize this on purpose or should it be lowercase like the other error messages? Same question below.


https://reviews.llvm.org/D48344





More information about the llvm-commits mailing list