[PATCH] D48106: implemented proto to llvm
    Matt Morehouse via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Jun 19 17:38:44 PDT 2018
    
    
  
morehouse accepted this revision.
morehouse added inline comments.
This revision is now accepted and ready to land.
================
Comment at: tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:50
+          errs() << "error: opt level must be between 0 and 3.\n";
+          std::exit(0);
+      }
----------------
`exit(1)` will indicate an abnormal exit.  (here and below)
================
Comment at: tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:64
+  SMDiagnostic Err;
+  // Create a new Context
+  LLVMContext Context;
----------------
This comment is unnecessary.  Clearly a new Context is being created on the next line.
Repository:
  rC Clang
https://reviews.llvm.org/D48106
    
    
More information about the llvm-commits
mailing list