[PATCH] D48333: [MemorySSA] Verify Phi incoming blocks are block predecessors.

George Burgess IV via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 19 17:36:00 PDT 2018


george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.

LGTM after a nit is fixed; thanks!



================
Comment at: lib/Analysis/MemorySSA.cpp:1751
         verifyUseInDefs(Phi->getIncomingValue(I), Phi);
+        assert(llvm::find(predecessors(&B), Phi->getIncomingBlock(I)) !=
+                   pred_end(&B) &&
----------------
nit: I think you can drop the `llvm::` and just spell this `find(`.


Repository:
  rL LLVM

https://reviews.llvm.org/D48333





More information about the llvm-commits mailing list