[PATCH] D48336: Adding mutation usefulness metric

[Jonathan Metzman via Phabricator via llvm-commits]

metzman added a comment.

I assumed I was supposed to review this. +1 to Max's comment about saying "PTAL"
I don't really think this should be its own option. I'd just print the percentages, but I think this is for Max to decide since he has in mind what will be done with the stats better than I.



================
Comment at: lib/fuzzer/FuzzerInternal.h:83
   void PrintFinalStats();
+  void PrintMutationStats();
+  void PrintMutationUsefulness();
----------------
I think it would better if PrintFinalStats handled printing of all stats including the mutation ones, instead of calling these three functions all over.


================
Comment at: lib/fuzzer/FuzzerMutationStats.cpp:70
 
-}  // namespace fuzzer
+} // namespace fuzzer
----------------
This looks like an unnecessary change, please undo


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D48336