[PATCH] D48275: [mips] Add microMIPS specific addressing patterns.

[Stefan Maksimovic via Phabricator via llvm-commits]

smaksimovic accepted this revision.
smaksimovic added a comment.
This revision is now accepted and ready to land.

Looks okay, one small remark



================
Comment at: test/CodeGen/Mips/address-selection.ll:2
+; RUN: llc -march=mips < %s -debug 2>&1 | FileCheck %s --check-prefix=MIPS
+; RUN: llc -march=mips -relocation-model=pic -mips-fix-global-base-reg=true < %s -debug 2>&1 | FileCheck %s --check-prefix=MIPS-PIC
+; RUN: llc -march=mips -relocation-model=pic -mxgot < %s -debug 2>&1 | FileCheck %s --check-prefix=MIPS-XGOT
----------------
It looks like the MIPS-PIC prefix is not used anywhere in this test.


================
Comment at: test/CodeGen/Mips/address-selection.ll:6
+; RUN: llc -march=mips -mattr=+micromips < %s -debug 2>&1 | FileCheck %s --check-prefix=MM
+; RUN: llc -march=mips -relocation-model=pic -mips-fix-global-base-reg=true < %s -debug 2>&1 | FileCheck %s --check-prefix=MIPS-PIC
+; RUN: llc -march=mips -relocation-model=pic -mxgot -mattr=+micromips < %s -debug 2>&1 | FileCheck %s --check-prefix=MM-XGOT
----------------
This line is identical to the one above.


Repository:
  rL LLVM

https://reviews.llvm.org/D48275