[llvm] r335042 - llvm-exegesis: mark ~ExegesisTarget() as virtual. Fixes build.

Roman Lebedev via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 19 04:58:10 PDT 2018


Author: lebedevri
Date: Tue Jun 19 04:58:10 2018
New Revision: 335042

URL: http://llvm.org/viewvc/llvm-project?rev=335042&view=rev
Log:
llvm-exegesis: mark ~ExegesisTarget() as virtual. Fixes build.

/build/llvm/tools/llvm-exegesis/lib/X86/../Target.h:32:3: error: 'exegesis::ExegesisTarget' has virtual functions but non-virtual destructor [-Werror,-Wnon-virtual-dtor]
  ~ExegesisTarget();
  ^
/build/llvm/tools/llvm-exegesis/lib/X86/Target.cpp:15:7: error: 'exegesis::(anonymous namespace)::ExegesisX86Target' has virtual functions but non-virtual destructor [-Werror,-Wnon-virtual-dtor]
class ExegesisX86Target : public ExegesisTarget {
      ^

Modified:
    llvm/trunk/tools/llvm-exegesis/lib/Target.h

Modified: llvm/trunk/tools/llvm-exegesis/lib/Target.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-exegesis/lib/Target.h?rev=335042&r1=335041&r2=335042&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-exegesis/lib/Target.h (original)
+++ llvm/trunk/tools/llvm-exegesis/lib/Target.h Tue Jun 19 04:58:10 2018
@@ -29,7 +29,7 @@ public:
   // Registers a target. Not thread safe.
   static void registerTarget(ExegesisTarget *T);
 
-  ~ExegesisTarget();
+  virtual ~ExegesisTarget();
 
 private:
   virtual bool matchesArch(llvm::Triple::ArchType Arch) const = 0;




More information about the llvm-commits mailing list