[PATCH] D48236: [IR] move shuffle mask queries from TTI to ShuffleVectorInst

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 19 03:38:36 PDT 2018


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with a slight addition to the comments - SLP for example supports alternate/permute cases for different sized inputs



================
Comment at: include/llvm/IR/Instructions.h:2514
+  /// Example: <7,6,-1,4>
+  /// This assumes that vector operands are the same length as the mask.
+  static bool isReverseMask(ArrayRef<int> Mask);
----------------
Make this comment in each case a TODO - at some point we're going to have to (optionally) support length changing shuffle patterns


https://reviews.llvm.org/D48236





More information about the llvm-commits mailing list