[PATCH] D48298: [ELF] Uniquify --wrap list.

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 18 15:34:22 PDT 2018


echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

One nit, otherwise LGTM.

-eric



================
Comment at: test/ELF/wrap.s:7
 // RUN: llvm-objdump -d -print-imm-hex %t3 | FileCheck %s
-// RUN: ld.lld -o %t3 %t %t2 --wrap foo -wrap=nosuchsym
+// RUN: ld.lld -o %t3 %t %t2 --wrap foo --wrap foo -wrap=nosuchsym
 // RUN: llvm-objdump -d -print-imm-hex %t3 | FileCheck %s
----------------
Small nit, I'd probably add a separate test for this rather than changing an existing one (even though it tests the same behavior) so we know in a smaller way if something in particular breaks.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D48298





More information about the llvm-commits mailing list