[PATCH] D48087: [TSan] Report proper error on allocator failures instead of CHECK(0)-ing

[Aleksey Shlyapnikov via Phabricator via llvm-commits]

alekseyshl added inline comments.


================
Comment at: lib/tsan/tests/unit/tsan_mman_test.cc:205
-               "allocator is terminating the process instead of returning 0");
-  EXPECT_EQ(0L, p);
-  // Alignment is not a multiple of sizeof(void*), although is a power of 2.
----------------
vitalybuka wrote:
> Why do you remove all these tests?
Death tests are covered by tests in sanitizer_common now, there's no point in duplicating them and DEATH tests here are a nuisance, check the comment above, next to "#if !SANITIZER_DEBUG".

memalign is not covered by common tests yet, but will be some time soon and then the last death test will be removed from here.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D48087