[compiler-rt] r334944 - [sanitizer] Guard call to internal_lseek when SANITIZER_MAC is true

Francis Visoiu Mistrih via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 18 06:53:51 PDT 2018


Author: thegameg
Date: Mon Jun 18 06:53:51 2018
New Revision: 334944

URL: http://llvm.org/viewvc/llvm-project?rev=334944&view=rev
Log:
[sanitizer] Guard call to internal_lseek when SANITIZER_MAC is true

r334881 breaks macOS bots because internal_lseek is not defined (neither
used on macOS):
http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/46240/consoleFull.

See discussion from r334881: https://reviews.llvm.org/rL334881

Modified:
    compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_libc_test.cc

Modified: compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_libc_test.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_libc_test.cc?rev=334944&r1=334943&r2=334944&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_libc_test.cc (original)
+++ compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_libc_test.cc Mon Jun 18 06:53:51 2018
@@ -113,7 +113,7 @@ TEST(SanitizerCommon, FileOps) {
 
   fd = OpenFile(tmpfile, WrOnly);
   ASSERT_NE(fd, kInvalidFd);
-#if SANITIZER_POSIX
+#if SANITIZER_POSIX && !SANITIZER_MAC
   EXPECT_EQ(internal_lseek(fd, 0, SEEK_END), 0u);
 #endif
   uptr bytes_written = 0;




More information about the llvm-commits mailing list