[PATCH] D48264: [MCA][NFC] Add generic XOP resource tests

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 18 06:51:08 PDT 2018


lebedev.ri added inline comments.


================
Comment at: test/tools/llvm-mca/X86/Generic/resources-xop.s:393
+vprotb $-9, %xmm0, %xmm3
+vprotb $-9, (%rax), %xmm3
+
----------------
RKSimon wrote:
> Is it useful to test rotl/rotr here? Isn't this more of a MC test?
[[ https://support.amd.com/TechDocs/43479.pdf | AMD64 Architecture Programmer’s Manual Volume 6: 128-Bit and 256-Bit XOP and FMA4 Instructions ]], page 239:
```
VPROTB Packed Rotate Bytes 
...
The VPROTB instruction is an XOP instruction.
```
So i think we want to test the form with immediate here?
Or is the question about testing multiple immediate?


Repository:
  rL LLVM

https://reviews.llvm.org/D48264





More information about the llvm-commits mailing list