[PATCH] D48277: [DebugInfo] Keep DBG_VALUE undef in LiveDebugVariables

Mikael Holmén via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 18 05:34:42 PDT 2018


uabelho added a comment.

I don't know this code very well so I did an attempt to remove the undef removal, and then I ran a bunch of tests to see what
would go wrong. I then ended up in failed assertions when trying to find the undef value in "locations" and "LocNoMap" so
I gurded that with !isUndef() checks.

Does this make sense? Any other obvious cases where we need to do something special with undef?

We could perhaps change the "getLocationNo" method so it inserts an undef value in "locations" as well, but I've no idea
if that would make anything better.


https://reviews.llvm.org/D48277





More information about the llvm-commits mailing list