[PATCH] D47659: Give same-named members unique timestamps on Darwin in llvm-ar.

[James Y Knight via Phabricator via llvm-commits]

jyknight marked 2 inline comments as done.
jyknight added inline comments.


================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:501
+      // Increment timestamp for each file of a given name.
+      ModTime = sys::toTimePoint(FilenameCount[M.MemberName]++);
+    else
----------------
JDevlieghere wrote:
> I wonder if we should include the original timestamp in the calculation? I don't know if it's worth the extra work of keeping track of these artificial ones, as we'd need to ensure they don't crash with real timestamps. 
This code is only used in Deterministic mode, so there are no original timestamps to worry about.


https://reviews.llvm.org/D47659