[PATCH] D48147: Add comment to scatter-bit operation, make it faster and rename it.

Sid Manning via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 15 13:13:25 PDT 2018


sidneym accepted this revision.
sidneym added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/ELF/Arch/Hexagon.cpp:57
+    if (Mask & (1 << I))
+      Res |= !!(Val & (1 << Off++)) << I;
+  return Res;
----------------
The comment above is helpful but I'll be honest and say that the above line wouldn't be the first thing to pop into my head.


https://reviews.llvm.org/D48147





More information about the llvm-commits mailing list