[PATCH] D47999: cl::opt ForceTrackRegLiveness for forcing liveness tracking on MIR (in MIR-Parser)

Puyan Lotfi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 15 10:51:19 PDT 2018


plotfi added a comment.

Ah yeah, I like that suggestion. Do you think it would be better to add the property by default rather than have a flag?
So a lot of the mir tests don't have this line added but if we added it by default a simple cat foo.mir | llc -run-pass=none -x mir -o - could add the  "tracksRegLiveness: true"
property that is needed to do the full pipeline. Or maybe not having "tracksRegLiveness:" at all should imply "tracksRegLiveness: true" ?

I think it would be good to discuss probably what the sane defaults should be here.

PL

In https://reviews.llvm.org/D47999#1133723, @qcolombet wrote:

> Hi Puyan,
>
> If that property is required for proper processing, why don't we print it in the mir file?
>
> Adding an option to force that sounds wrong to me.
>
> Cheers,
> -Quentin





Repository:
  rL LLVM

https://reviews.llvm.org/D47999





More information about the llvm-commits mailing list