[PATCH] D48203: [SanitizerCoverage] Add associated metadata to pc-tables.

[Matt Morehouse via Phabricator via llvm-commits]

morehouse added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:409
     appendToUsed(M, GlobalsToAppendToUsed);
+    appendToCompilerUsed(M, GlobalsToAppendToCompilerUsed);
+  }
----------------
eugenis wrote:
> morehouse wrote:
> > eugenis wrote:
> > > this is unnecessary, llvm.used is strictly stronger than llvm.compiler.used
> > I'm not sure I understand...  We're appending different things to each list.
> Right. Sorry.
> A different question then: why only MachO?
Kostya mentioned his reasoning in http://lists.llvm.org/pipermail/llvm-dev/2017-September/117315.html.


https://reviews.llvm.org/D48203