[PATCH] D48203: [SanitizerCoverage] Add associated metadata to pc-tables.

Matt Morehouse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 15 09:53:33 PDT 2018


morehouse added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:409
     appendToUsed(M, GlobalsToAppendToUsed);
+    appendToCompilerUsed(M, GlobalsToAppendToCompilerUsed);
+  }
----------------
eugenis wrote:
> this is unnecessary, llvm.used is strictly stronger than llvm.compiler.used
I'm not sure I understand...  We're appending different things to each list.


https://reviews.llvm.org/D48203





More information about the llvm-commits mailing list