[PATCH] D43542: [CodeGen][FastRegAlloc] Disable registers spilling for a naked function (PR28641)

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 15 08:57:11 PDT 2018


qcolombet added a comment.

Hi Konstantin,

> We can add Live Variable Analysis pass prior of execution of Fast Register Allocator pass, but this will cause ~59 LIT tests to fail.

IIRC we were trying to get rid of the Live Variable Analysis pass all together. Therefore, adding uses of this pass is not recommended.
That said, for O0 I don't know what would be the alternative.

Anyway, if that pass does what we want, adding it at O0 works. Fixing LIT tests is fine.

Cheers,
-Quentin


https://reviews.llvm.org/D43542





More information about the llvm-commits mailing list