[PATCH] D48199: [scudo] Add verbose failures in place of CHECK(0)

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad added inline comments.


================
Comment at: lib/scudo/scudo_allocator.cpp:328
   // it can, every 100ms, otherwise it will just return the current one.
-  bool isRssLimitExceeded() {
+  NOINLINE bool isRssLimitExceeded() {
     u64 LastCheck = atomic_load_relaxed(&RssLastCheckedAtNS);
----------------
filcab wrote:
> Maybe also define it out of line? No use making the class definition harder to read if we don't even want to inline this function.
Let me remove that from this CL, and in another I can add it and move definitions of `isRssLimitExceeded` & `performSanityChecks` out of line.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D48199