[PATCH] D48201: [cmake] Add linker detection for Apple platforms

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 14 16:12:02 PDT 2018


smeenai added inline comments.


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:157
+  if("${stderr}" MATCHES "PROJECT:ld64")
+    set(LLVM_LINKER_IS_LD64 ON)
+    message(STATUS "Linker detection: ld64")
----------------
compnerd wrote:
> `YES` is better than `ON` here IMO
I'll change this (and all the ones below) in a follow-up.


Repository:
  rL LLVM

https://reviews.llvm.org/D48201





More information about the llvm-commits mailing list