[PATCH] D48183: [WebAssembly] Modified tablegen defs to have 2 parallel instuction sets.

[Jacob Gravelle via Phabricator via llvm-commits]

jgravelle-google added a comment.

Overall  looks ok



================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrMemory.td:157
+defm LOAD16_S_I64 : WebAssemblyLoad<I64, "i64.load16_s", 0x32>;
+defm LOAD16_U_I64 : WebAssemblyLoad<I64, "i64.load16_u", 0x32>;
+defm LOAD32_S_I64 : WebAssemblyLoad<I64, "i64.load32_s", 0x34>;
----------------
Why did the the binary encoding change from 0x33 to 0x32 here?


Repository:
  rL LLVM

https://reviews.llvm.org/D48183