[PATCH] D48141: [ASan] Linker-initialize static ScopedInErrorReport::current_error_.

[Aleksey Shlyapnikov via Phabricator via llvm-commits]

alekseyshl added a comment.

In https://reviews.llvm.org/D48141#1132214, @delcypher wrote:

> In https://reviews.llvm.org/D48141#1131594, @alekseyshl wrote:
>
> > In https://reviews.llvm.org/D48141#1131507, @delcypher wrote:
> >
> > > Isn't this basically https://reviews.llvm.org/D44243 ?
> >
> >
> > It is! Thanks, missed that one. I'm fine with that one being committed too. Is the explanation on this patch satisfactory?
>
>
> minor nit: s/on the startup/on application startup/ or s/on the startup/on startup/
>
> I'm fine with either patch. My issue with https://reviews.llvm.org/D44243 is that the reason for the change wasn't provided.  The explanation you provide was satisfactory once I read https://github.com/google/sanitizers/issues/194 . 
>  Without reading the github issue it's not so clear what _asan_init-safe means. I'll leave it up to you to decide whether you want the commit message to be clear when read on its own or whether
>  referencing the GitHub issue is sufficient.


Thank you for the suggestions, updated the message to provide a bit more inline context.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D48141