[PATCH] D47874: [SCEVExp] Advance found insertion point until we find a non-dbg instruction.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 14 08:57:44 PDT 2018


aprantl added a comment.

In https://reviews.llvm.org/D47874#1132374, @fhahn wrote:

> I've updated the patch to add a skipDebugInstructionsForward utility. We have a very similar function defined in MachineBasicBlock.h, maybe we should consolidate those functions?


The MachineBasicBlock.h function operates on MachineInstrs the one in BasicBlock operates on Instructions. I'm not sure how to unify these: perhaps by adding a skipForwardWhile(std::function(bool() shouldSkip) primitive to ilist?


https://reviews.llvm.org/D47874





More information about the llvm-commits mailing list