[PATCH] D24960: Remove unreachable from apis in posix terminal compat windows and return 0

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 14 08:14:14 PDT 2018

Previous message: [PATCH] D24960: Remove unreachable from apis in posix terminal compat windows and return 0
Next message: [llvm] r334704 - [DebugInfo] Check size of variable in ConvertDebugDeclareToDebugValue
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

clayborg added a comment.

shouldn't these be returning -1 for some of these? Zero usually means no error. You would need to check each unix function and return the right error code for failure.


Repository:
  rL LLVM

https://reviews.llvm.org/D24960

Previous message: [PATCH] D24960: Remove unreachable from apis in posix terminal compat windows and return 0
Next message: [llvm] r334704 - [DebugInfo] Check size of variable in ConvertDebugDeclareToDebugValue
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list