[PATCH] D47736: AMDHSA Code Object v3 assembler syntax update

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 13 18:50:42 PDT 2018


kzhuravl added inline comments.


================
Comment at: lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:2708
+
+  getTargetStreamer().EmitAMDGPUSymbolType(KernelName,
+                                           ELF::STT_AMDGPU_HSA_KERNEL);
----------------
I think we should not be emitting this for v3.


https://reviews.llvm.org/D47736





More information about the llvm-commits mailing list