[PATCH] D48153: Add TARGET(foo) linker script directive.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 13 14:57:16 PDT 2018


ruiu added inline comments.


================
Comment at: lld/ELF/ScriptParser.cpp:486
+
+  if (Tok.startswith("elf"))
+    Config->FormatBinary = false;
----------------
rdhindsa wrote:
> Should "default" case be handled here as well?
I don't think so. We add features as-needed basis, so we don't add a lot of features ahead of time.


https://reviews.llvm.org/D48153





More information about the llvm-commits mailing list