[PATCH] D48049: Add a new SBTarget::LoadCore() overload which surfaces errors if the load fails

[Jim Ingham via Phabricator via llvm-commits]

jingham added a comment.

SBTarget.Attach, and Launch take SBError references, and they are pretty well tested.  So I don't think that's a concern here.

We don't use the text content of error messages programmatically in lldb.

If you wanted to make these errors actionable, the low level LoadCore could map the errors that are representable as such to the appropriate Posix error number.  Then you could get the error value, and reason based on that.  We do that in a bunch of places, but always either in explicitly Posix code - or with the Mach error flavor in Mach specific code.  It would be a little weird to return Posix FNF on a Windows host, however...

But that's well outside the scope of this patch.  And given we don't do that now, I agree with Leonard, we shouldn't require some form for the error text here.


Repository:
  rL LLVM

https://reviews.llvm.org/D48049