[PATCH] D48135: [DWARFv5] Tolerate files not all having an MD5 checksum.

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: llvm/include/llvm/MC/MCDwarf.h:258
+    else
+      Header.HasAllMD5 = false;
     Header.HasSource = Source.hasValue();
----------------
aprantl wrote:
> I found that a little confusing to read at first:
> what do you think about
> ```
> Header.HasAnyMD5 |= CheckSum;
> Header.HasAllMD5 &= CheckSum;
> ```
> to underline the fact that these values are updated incrementally?
It would have to be spelled `bool(CheckSum)` or maybe you would prefer `(CheckSum != nullptr))` but yes that does work.


https://reviews.llvm.org/D48135