[PATCH] D47574: [EarlyCSE] Propagate conditions of AND and OR instructions

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

Current patch LGTM.

As a follow up, I think it might make sense to refactor the interface of the helper a bit.  In particular, you have the SimpleValue::canHandle logic both in the caller and the callee.  Might make sense to sink it into the callee only and check when taking items out of the worklist.

Danny, I'm not quite clear why PredicateInfo is the right direction to take here?  Can you explain?  Probably best done on llvm-dev instead of an individual review thread just so we have a wider audience.


https://reviews.llvm.org/D47574