[PATCH] D48135: [DWARFv5] Tolerate files not all having an MD5 checksum.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 13 10:13:54 PDT 2018


aprantl added inline comments.


================
Comment at: llvm/include/llvm/MC/MCDwarf.h:258
+    else
+      Header.HasAllMD5 = false;
     Header.HasSource = Source.hasValue();
----------------
I found that a little confusing to read at first:
what do you think about
```
Header.HasAnyMD5 |= CheckSum;
Header.HasAllMD5 &= CheckSum;
```
to underline the fact that these values are updated incrementally?


Repository:
  rL LLVM

https://reviews.llvm.org/D48135





More information about the llvm-commits mailing list