[PATCH] D48112: Simplify PPC64::calcEFlags().

[Sean Fertile via Phabricator via llvm-commits]

sfertile accepted this revision.
sfertile added a comment.
This revision is now accepted and ready to land.

Other then the 1 comment this LGTM.



================
Comment at: lld/ELF/Arch/PPC64.cpp:121
+    if (Flag != 0 && Flag != 2)
+      error(toString(F) + ": ABI version " + Twine(Flag) + " is not supported");
   }
----------------
I think we should still emit 2 separate error messages:

1) if flags & 1 is set then emit an error message that reflects we don't support the V1 abi.
2) if any flags bits other then bits 1 or 2 are set then we emit a message for unrecognized e_flags.


https://reviews.llvm.org/D48112