[PATCH] D47922: unsigned foo(unsigned x, unsigned y) { return x > y && x != 0; } should fold to x > y

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In https://reviews.llvm.org/D47922#1130979, @HLJ2009 wrote:

> In https://reviews.llvm.org/D47922#1130939, @lebedev.ri wrote:
>
> > And now,
> >
> >   $ cd llvm
> >   $ git checkout master # the svn trunk
> >   $ arc patch D47922 
> >   $ # unstage the test/test/Transforms/InstSimplify/AndOrXor.ll from last commit, delete that leftover file.
> >   $ git rebase arcpatch-D48000 arcpatch-D47922
> >   $ cd ../llvm-build/ # or whereever
> >   $ ninja
> >   $ ../llvm/utils/utils/update_test_checks.py --opt-binary ./bin/opt ../llvm/test/test/Transforms/InstSimplify/AndOrXor.ll
> >   $ git commit --amend
> >   $ git diff -p -U99999 arcpatch-D48000..arcpatch-D48000 > /tmp/patch.patch # i.e. from D48000 (!!! *not* svn trunk/git master) to this patch
> >   $ # Update this differential with that patch.
> >
>
>
> hi ,
>
>   when I use git rebase arcpatch-D48000 arcpatch-D47922 command, I found this error fatal: Needed a single revision ,invalid upstream arcpatch-D48000
>   Do I have such permission to do such a thing?


You obviously need to do that in the very same repo clone where you did https://reviews.llvm.org/D48000#1130858
I would really suggest reading something about git, the workflow, basic commands..


Repository:
  rL LLVM

https://reviews.llvm.org/D47922