[PATCH] D47587: [RISCV] Codegen support for atomic operations on RV32I

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 13 04:58:14 PDT 2018


asb added inline comments.


================
Comment at: lib/Target/RISCV/RISCVInstrInfo.td:756
+// fence acq_rel -> fence.tso
+def : Pat<(atomic_fence (i32 6), (imm)), (FENCE_TSO)>;
+// fence seq_cst -> fence rw, rw
----------------
jyknight wrote:
> Did you miss uploading the part of the change to add a definition of FENCE_TSO? I don't see where that's defined here.
> 
> But marking LGTM anyways, assuming that'll get fixed before commit.
I committed MC layer support for fence.tso directly (i.e. with post-commit review). MC layer fence.tso support is logically independent of this patch, and the patch was trivial. See rL334278.


https://reviews.llvm.org/D47587





More information about the llvm-commits mailing list