[PATCH] D47098: [ELF] Support R_X86_64_GOTPC{32,64}

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 12 12:44:52 PDT 2018


ruiu added inline comments.


================
Comment at: test/ELF/x86-64-reloc-got.s:11
+// 0x3070 (.got end) - 0x1007 = 8297
+// CHECK: R_X86_64_GOTPC32:
+// CHECK-NEXT: 1000: {{.*}} leaq 8297(%rip), %r15
----------------
ruiu wrote:
> Let's avoid using the exact same name for both relocation type and function name. That's very confusing to humans when reading disassembly. Just fn1 and fn2 should suffice.
Can you fix?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47098





More information about the llvm-commits mailing list