[PATCH] D48032: [RegisterCoalescer] Avoid erasing copy that breaks subranges
Tim Renouf via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 12 12:31:19 PDT 2018
tpr updated this revision to Diff 150995.
tpr added a comment.
V2: This is a revised fix. Still not the proper fix, but at least it
doesn't stop a copy being erased.
Also tidied the test as suggested.
Here's the new commit message, as I don't think phabricator updates the
summary box:
[RegisterCoalescer] Recalculate subranges in some cases
Summary:
I found a case where erasing a copy in coalescing causes a subrange to
be modified incorrectly.
It looks like it would be quite a large change to fix this properly,
such that subranges are updated correctly when a subreg is dead in and
live out of a copy being erased.
So for now, in the case causing my problem, it now just recalculates
the whole live interval after the coalesce.
Repository:
rL LLVM
https://reviews.llvm.org/D48032
Files:
lib/CodeGen/RegisterCoalescer.cpp
lib/CodeGen/RegisterCoalescer.h
test/CodeGen/AMDGPU/coalescing-with-subregs-in-loop-bug.mir
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48032.150995.patch
Type: text/x-patch
Size: 14138 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180612/c8123d8e/attachment.bin>
More information about the llvm-commits
mailing list