[PATCH] D47566: AMDHSA: Code object v3 updates

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 12 11:42:06 PDT 2018


kzhuravl closed this revision.
kzhuravl marked an inline comment as done.
kzhuravl added a comment.

https://reviews.llvm.org/rL334519



================
Comment at: lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp:381
+  Streamer.PushSection();
+  Streamer.SwitchSection(&ReadOnlySection);
+
----------------
scott.linder wrote:
> Should this switch be happening here? Shouldn't the assembly writer be able to put this descriptor in any section?
rL334521


https://reviews.llvm.org/D47566





More information about the llvm-commits mailing list