[PATCH] D47919: llvm-readobj: add experimental support for SHT_RELR sections.

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich added inline comments.


================
Comment at: include/llvm/BinaryFormat/ELF.h:1077
+// Relocation entry without explicit addend or info (relative relocations only).
+struct Elf32_Relr {
+  Elf32_Word r_data; // offset/bitmap for relative relocations
----------------
mcgrathr wrote:
> jakehehrlich wrote:
> > I think in the spec you propose Elf32_Relr and Elf64_Relr as typedefs instead of structs. I think this file (and the higher level ELFType file as well) should match the spec in that regard.
> This header is C++, not C.  So there's no difference there.
That's not my point. The spec proposal I'm working off of reads

```
  typedef Elf32_Word   Elf32_Relr; 
  typedef Elf64_Xword  Elf64_Relr; 
```

This file should match (not precisely, it can use using instead of typedef if it wants) in that it should not have to go though an r_data field. Alternatively the spec can be updated to make this a struct.


Repository:
  rL LLVM

https://reviews.llvm.org/D47919