[PATCH] D44620: [XRay][profiler] Part 4: Profiler Mode Wiring

[Dean Michael Berris via Phabricator via llvm-commits]

dberris marked 5 inline comments as done.
dberris added a comment.

In https://reviews.llvm.org/D44620#1127115, @kpw wrote:

> I'm going to have to download the renamed files to diff locally. Is there a way to do this in Differential that I'm missing?


I'm not sure, but it looks like Differential already sees the rename/merge -- is there something else you're looking for?



================
Comment at: compiler-rt/test/xray/TestCases/Posix/profiling-multi-threaded.cc:8
+//
+// UNSUPPORTED: target-is-mips64,target-is-mips64el
+
----------------
kpw wrote:
> dberris wrote:
> > kpw wrote:
> > > Do you need a thing to exclude windows since you're calling readtsc()
> > Good point. Yes, need to require Linux for now.
> I think this still must be done before you submit.
I looked into this and we already only enable all the tests for Linux from the lit configurations.


https://reviews.llvm.org/D44620