[PATCH] D47898: IRMover: Account for matching types present across modules

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 11 12:42:24 PDT 2018


pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Linker/IRMover.cpp:262-265
   if (!IsUniqued && !Visited.insert(cast<StructType>(Ty)).second) {
     StructType *DTy = StructType::create(Ty->getContext());
     return *Entry = DTy;
   }
----------------
This could be moved inside the `if (!IsUniqued)` block.


Repository:
  rL LLVM

https://reviews.llvm.org/D47898





More information about the llvm-commits mailing list