[PATCH] D47975: [ELF] Fix copy relocation when two symbols share the same Symbol instance.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 11 11:30:42 PDT 2018


ruiu added a comment.

Could you add a test?



================
Comment at: ELF/Relocations.cpp:454
 
-  std::vector<SharedSymbol *> Ret;
+  // Use a set to deduplicate symbols.
+  SmallSet<SharedSymbol *, 4> Ret;
----------------
I don't think you need this comment.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47975





More information about the llvm-commits mailing list